saethlin commented on a change in pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#discussion_r449168566



##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
 edition = "2018"
 
 [dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"

Review comment:
       I don't know for certain. Things _might_ work with `~2.6`, but that does 
not forbid Cargo from selecting `2.6.0` and I've recently been fighting a lot 
with a few problems that arise because `cargo publish` runs `cargo update` and 
crate maintainers in general tend to update their lockfiles often, so sometimes 
a `Cargo.toml` dependency requirement includes options that are invalid.
   
   Here's an example of a similar (but not exactly the same) problem, where the 
dependency specification includes things that do and don't compile: 
https://github.com/achanda/ipnetwork/issues/132
   
   My perspective is that I'd rather be safe than sorry, but if you'd rather be 
conservative in what gets changed in the project I understand and I have no 
problem with opening a separate PR when this causes problems.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to