jacques-n commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-653348862
This doesn't just break Dremio tests, it breaks Dremio functionally. A little history lesson: ValueVector.getBuffers() has existed for a much longer time than FieldVector.getFieldBuffers(). It behaves differently, uses less memory and is on a higher level abstraction. I don't think it makes sense to remove this without more thought around all those issues and I definitely think it should be done with step 1 being deprecation and step 2 being removal. Let's constrain this patch to what it was originally intended to solve and not try to consolidate the two different buffer retrieval interfaces. There are definitely scenarios where we want to view the buffers unchanged (getFieldBuffers) and where we want to export them for writing (getBuffers). We should figure out what the consolidated interface is before removing something useful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
