jianxind commented on a change in pull request #7607: URL: https://github.com/apache/arrow/pull/7607#discussion_r451916262
########## File path: cpp/src/arrow/compute/kernels/aggregate_sum_avx2.cc ########## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/kernels/aggregate_basic_internal.h" + +namespace arrow { +namespace compute { +namespace aggregate { + +// ---------------------------------------------------------------------- +// Sum implementation + +// Round size optimized based on data type and compiler +template <typename T> +struct RoundSizeAvx2 { + static constexpr int64_t size = 32; +}; + +// Round size set to 64 for float/int32_t/uint32_t +template <> +struct RoundSizeAvx2<float> { + static constexpr int64_t size = 64; +}; + +template <> +struct RoundSizeAvx2<int32_t> { + static constexpr int64_t size = 64; +}; + +template <> +struct RoundSizeAvx2<uint32_t> { + static constexpr int64_t size = 64; +}; + +template <typename ArrowType> +struct SumImplAvx2 + : public SumImpl<RoundSizeAvx2<typename TypeTraits<ArrowType>::CType>::size, + ArrowType> {}; + +template <typename ArrowType> +struct MeanImplAvx2 + : public MeanImpl<RoundSizeAvx2<typename TypeTraits<ArrowType>::CType>::size, + ArrowType> {}; + +std::unique_ptr<KernelState> SumInitAvx2(KernelContext* ctx, const KernelInitArgs& args) { + SumLikeInit<SumImplAvx2> visitor(ctx, *args.inputs[0].type); + return visitor.Create(); +} + +std::unique_ptr<KernelState> MeanInitAvx2(KernelContext* ctx, + const KernelInitArgs& args) { + SumLikeInit<MeanImplAvx2> visitor(ctx, *args.inputs[0].type); + return visitor.Create(); +} + +} // namespace aggregate + +namespace internal { + +void RegisterScalarAggregateSumAvx2(FunctionRegistry* registry) { + auto func = std::make_shared<ScalarAggregateFunction>("sum", Arity::Unary()); + aggregate::AddBasicAggKernels(aggregate::SumInitAvx2, {boolean()}, int64(), func.get()); + aggregate::AddBasicAggKernels(aggregate::SumInitAvx2, SignedIntTypes(), int64(), + func.get()); + aggregate::AddBasicAggKernels(aggregate::SumInitAvx2, UnsignedIntTypes(), uint64(), + func.get()); + aggregate::AddBasicAggKernels(aggregate::SumInitAvx2, FloatingPointTypes(), float64(), + func.get()); + // Register the override AVX2 version + DCHECK_OK(registry->AddFunction(std::move(func), true)); Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
