pitrou commented on a change in pull request #7755:
URL: https://github.com/apache/arrow/pull/7755#discussion_r454550954
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc
##########
@@ -61,9 +61,9 @@ static void IsAlphaNumericAscii(benchmark::State& state) {
UnaryStringBenchmark(state, "ascii_isalnum");
}
-static void BinaryContainsExact(benchmark::State& state) {
- BinaryContainsExactOptions options("abac");
- UnaryStringBenchmark(state, "binary_contains_exact", &options);
+static void MatchSubstring(benchmark::State& state) {
+ MatchSubstringOptions options("abac");
+ UnaryStringBenchmark(state, "match_substring", &options);
Review comment:
I don't think so. Personally, I find prefixes a bit pointless or even
distracting.
(or, here, plain misleading, since "binary_contains_exact" didn't work on
binary arrays, only string arrays...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
