jorgecarleitao commented on pull request #7751:
URL: https://github.com/apache/arrow/pull/7751#issuecomment-658906785


   > Thanks @jorgecarleitao . Great that the `Date32` is covered. Is it 
possible to add a test for `Date64` as well or it is also covered? Ideally we 
want to test the error case as well but not sure how difficult it is to come up 
with such a test.
   
   I tried, but I admit that I am not very familiar with the code base nor the 
theory, so you will have to help me out here.
   
   My current hypothesis is that parquet's logical type for dates is "DATE" 
annotated as a i32 [as per 
perquet-format](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#date).
 Date64 is an arrow specific format, and thus to test it we need to have a file 
in parquet with that format, since we do not have a writer yet to play around. 
We could do it in memory, but then I was unable to find a good example in the 
tests to base myself on.
   
   I was hoping to find a place in the code where we do a serialize-deserialize 
roundtrip and assert that the result is the same for *every* type that we 
declare. I have been doing this on a package that I have been writing, 
[here](https://github.com/jorgecarleitao/datafusion-python/blob/master/tests/test_sql.py#L202),
 and that is where I found the bug, but I can't find a place in `arrow/rust` 
where we are performing this test consistently. Do you know where I can find 
this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to