andygrove commented on pull request #7894:
URL: https://github.com/apache/arrow/pull/7894#issuecomment-669969605
@vertexclique The release scripts now need updating. I spent some time
trying to fix them myself this morning but I am out of time for now.
To reproduce locally you can run:
```
./ci/scripts/release_test.sh $(pwd)
```
If you look at `00-prepare.sh` you will see it does this:
```
sed -i.bak -E \
-e "s/^version = \".+\"/version = \"${version}\"/g" \
-e "s/^(arrow = .* version = )\".+\"( .*)/\\1\"${version}\"\\2/g" \
-e "s/^(arrow-flight = .* version = )\".+\"( .*)/\\1\"${version}\"\\2/g"
\
-e "s/^(parquet = .* version = )\".+\"( .*)/\\1\"${version}\"\\2/g" \
*/Cargo.toml
```
Then in `00-prepare-test.rb` it checks for expected results and this is the
part that needs updating, to add the feature flags. There are two sections that
need updating and they are very similar. Here is one of them:
```
{
path: "rust/datafusion/Cargo.toml",
hunks: [
["-version = \"#{@snapshot_version}\"",
"+version = \"#{@release_version}\""],
["-arrow = { path = \"../arrow\", version =
\"#{@snapshot_version}\" }",
"-parquet = { path = \"../parquet\", version =
\"#{@snapshot_version}\" }",
"+arrow = { path = \"../arrow\", version =
\"#{@release_version}\" }",
"+parquet = { path = \"../parquet\", version =
\"#{@release_version}\" }"],
["-arrow-flight = { path = \"../arrow-flight\",
version = \"#{@snapshot_version}\" }",
"+arrow-flight = { path = \"../arrow-flight\",
version = \"#{@release_version}\" }"]
],
},
```
This is showing the expected diff after changing version numbers, but it no
longer matches because of the feature flags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
