jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471652148
##########
File path: rust/datafusion/src/sql/planner.rs
##########
@@ -515,27 +515,29 @@ impl<S: SchemaProvider> SqlToRel<S> {
}
_ => match self.schema_provider.get_function_meta(&name) {
Some(fm) => {
- let rex_args = function
Review comment:
AFAI recall, optimizations happen on the logical plan alone. Also, I
think that 52218c8 removes the coercion in constructing the logical, not
physical, plan (SQL nodes -> physical).
If this is the case, `logical -> physical` does not have to worry about
these, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
