kszucs commented on a change in pull request #12698:
URL: https://github.com/apache/arrow/pull/12698#discussion_r834283962
##########
File path: dev/archery/archery/lang/python.py
##########
@@ -139,10 +143,19 @@ def traverse(self, fn, obj, from_package):
continue
member = getattr(obj, name)
- module = getattr(member, '__module__', None)
- if not (module and module.startswith(from_package)):
+ module = _get_module(member)
+ if module is None or not module.startswith(from_package):
continue
-
+ # Is it a Cython-generated method? If so, try to detect
+ # whether it has a implicitly-generated docstring due to
+ # the Cython `embedsignature` directive; and if so, skip
Review comment:
Ohh I think the comment is a bit misleading. So the condition below only
skips if there is a signature but no docstrings, right? So for example it still
validates the following:
```python
In [9]: print(ds.Dataset.get_fragments.__doc__)
Dataset.get_fragments(self, Expression filter=None)
Returns an iterator over the fragments in this dataset.
Parameters
----------
filter : Expression, default None
Return fragments matching the optional filter, either using the
partition_expression or internal information like Parquet's
statistics.
Returns
-------
fragments : iterator of Fragment
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
