wjones127 commented on a change in pull request #12536:
URL: https://github.com/apache/arrow/pull/12536#discussion_r834396274
##########
File path: cpp/src/arrow/public_api_test.cc
##########
@@ -103,4 +104,40 @@ TEST(Misc, BuildInfo) {
ASSERT_THAT(info.full_so_version, ::testing::HasSubstr(info.so_version));
}
+TEST(Misc, SetTimzoneConfig) {
+#ifndef _WIN32
+ GTEST_SKIP() << "Can only set the Timezone database on Windows";
+#else
+#ifndef ARROW_FILESYSTEM
+ GTEST_SKIP() << "Need filesystem support to test timezone config.";
+#else
+ auto fs = std::make_shared<arrow::fs::LocalFileSystem>();
+ auto home_raw = std::getenv("USERPROFILE");
+ std::string home = home_raw == nullptr ? "~" : std::string(home_raw);
+ ASSERT_OK_AND_ASSIGN(std::string tzdata_dir,
+ fs->NormalizePath(home + "\\Downloads\\tzdata"));
Review comment:
I haven't worked much in the compute codebase. @rok any suggestion for a
good place to lazy initialize the timezone database?
I think there's several kernals across scalar_temporal_binary and
scalar_temporal_unary that use the db. And I wouldn't want to make it easy to
accidentally use the timezone db before it had been initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
