westonpace commented on pull request #12721: URL: https://github.com/apache/arrow/pull/12721#issuecomment-1079557118
> One question, does this take care of ‘SinkNode’ and ‘OrderBySink’ node too? It doesn't currently fix `SinkNode` or `OrderBySinkNode`. We could add an init-style schema callback to the options objects for those types. I'll try it out. > Another Advantage is we may be solving this issue too. https://issues.apache.org/jira/browse/ARROW-15297 Almost, looks like the python test is failing that was failing on that issue too. I think we can move towards `WriteNodeOptions` taking either an _optional_ schema (which would replace the one retrieved from the node, we could add a check to make sure they are compatible in the init step) or just a dictionary of metadata that we append to the schema in the init step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
