viirya commented on a change in pull request #1469:
URL: https://github.com/apache/arrow-rs/pull/1469#discussion_r835972012
##########
File path: arrow/src/array/equal/utils.rs
##########
@@ -161,8 +168,35 @@ pub(super) fn child_logical_null_buffer(
});
Some(buffer.into())
}
- DataType::Union(_, _) => {
- unimplemented!("Logical equality not yet implemented for union
arrays")
+ DataType::Union(_, mode) => {
+ match mode {
+ UnionMode::Sparse => {
+ // See the logic of `DataType::Struct` in
`child_logical_null_buffer`.
Review comment:
Made it as a function now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
