dragosmg commented on a change in pull request #12402:
URL: https://github.com/apache/arrow/pull/12402#discussion_r836793198
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -31,7 +31,7 @@ register_bindings_datetime <- function() {
unit <- make_valid_time_unit(unit, c(valid_time64_units,
valid_time32_units))
- Expression$create("strptime", x, options = list(format = format, unit =
unit))
+ build_expr("strptime", x, options = list(format = format, unit = unit,
error_is_null = TRUE))
})
Review comment:
For a moment I forgot we can always call the arrow function if we need
it. So 100% agree with you that we do not need to expose the arg to end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
