westonpace edited a comment on pull request #12721: URL: https://github.com/apache/arrow/pull/12721#issuecomment-1081324077
> I would probably prefer Init/Consume/Finish, we could default-implement Init if it's a concern I've updated this PR to use an `Init` method. I did not default-implement as I'm not sure any meaningful consumer can do much without the schema. I could add a default implementation that actually stored the schema (in a protected variable) but I kind of prefer pure-virtual interfaces for the public API, though maybe that is just my Java/C# background. Happy to change if anyone has any strong opinion on the matter. > Another Advantage is we may be solving this issue too. https://issues.apache.org/jira/browse/ARROW-15297 This changes the `schema` to an (optional) `custom_metadata` which I think means we do indeed solve ARROW-15297. > Shall we also add a few test cases to show the functionality? @vibhatha I've added a test to make sure we test the failure path (i.e. `Init` returns a non-ok status). I'm not sure what other test cases you had in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
