save-buffer commented on a change in pull request #12537:
URL: https://github.com/apache/arrow/pull/12537#discussion_r837743650
##########
File path: cpp/src/arrow/compute/exec/tpch_node.h
##########
@@ -42,40 +42,23 @@ class ARROW_EXPORT TpchGen {
* table from that single TpchGen instance. Note: Every batch will be
scheduled as a new
* task using the ExecPlan's scheduler.
*/
- static Result<TpchGen> Make(ExecPlan* plan, double scale_factor = 1.0,
- int64_t batch_size = 4096,
- util::optional<int64_t> seed = util::nullopt);
+ static Result<std::unique_ptr<TpchGen>> Make(
Review comment:
This does not need to be a unique_ptr. The whole point of using
shared_ptr for the order/lineitem and part/partsupp generators is so that this
TpchGen object can safely die.
Also none of the methods in this class need to be virtual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
