pitrou commented on a change in pull request #12537:
URL: https://github.com/apache/arrow/pull/12537#discussion_r837766413
##########
File path: cpp/src/arrow/compute/exec/tpch_node.h
##########
@@ -42,40 +42,23 @@ class ARROW_EXPORT TpchGen {
* table from that single TpchGen instance. Note: Every batch will be
scheduled as a new
* task using the ExecPlan's scheduler.
*/
- static Result<TpchGen> Make(ExecPlan* plan, double scale_factor = 1.0,
- int64_t batch_size = 4096,
- util::optional<int64_t> seed = util::nullopt);
+ static Result<std::unique_ptr<TpchGen>> Make(
Review comment:
As the commit title suggested, the point here is to hide implementation
details from the `.h`, and minimize header inclusion.
It can be a `unique_ptr`, a `shared_ptr` or the pimpl pattern, but any of
these patterns require some form of dynamic allocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
