save-buffer commented on pull request #12537: URL: https://github.com/apache/arrow/pull/12537#issuecomment-1082227200
Apologies, I'll not revert like that in the future. We can always revert the revert. As for the problem of increasing transitive inclusions, I agree keeping compilation time down is a worthy goal. I guess this header file now will transitively include `pcg_random.h`. Maybe we can find some other way to avoid including `pcg_random` without having to make everything virtual. I think either way we don't have to make the factory return a unique_ptr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
