pitrou commented on a change in pull request #12755: URL: https://github.com/apache/arrow/pull/12755#discussion_r838542907
########## File path: cpp/src/arrow/compute/exec/expression_execution_benchmark.cc ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "benchmark/benchmark.h" + +#include "arrow/compute/cast.h" +#include "arrow/compute/exec/expression.h" +#include "arrow/compute/exec/test_util.h" +#include "arrow/dataset/partition.h" +#include "arrow/testing/generator.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/type.h" + +namespace arrow { +namespace compute { + +auto expression = + and_(less(field_ref("x"), literal(20)), greater(field_ref("x"), literal(0))); + +static void Execution(benchmark::State& state) { + const auto array_batches = static_cast<int32_t>(state.range(0)); + const auto array_size = 10000000 / array_batches; + + ExecContext ctx; + auto dataset_schema = schema({ + field("x", int64()), + }); + ExecBatch input({Datum(ConstantArrayGenerator::Int64(array_size, 5))}, + /*length=*/1); + + ASSIGN_OR_ABORT(auto bound, expression.Bind(*dataset_schema)); + for (auto _ : state) { + for (int it = 0; it < array_batches; ++it) + ABORT_NOT_OK(ExecuteScalarExpression(bound, input, &ctx).status()); + } + state.SetBytesProcessed(state.iterations() * 8 * array_size); Review comment: Bytes-per-second is not really a measure of overhead, is it? ########## File path: cpp/src/arrow/compute/exec/expression_execution_benchmark.cc ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "benchmark/benchmark.h" + +#include "arrow/compute/cast.h" +#include "arrow/compute/exec/expression.h" +#include "arrow/compute/exec/test_util.h" +#include "arrow/dataset/partition.h" +#include "arrow/testing/generator.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/type.h" + +namespace arrow { +namespace compute { + +auto expression = + and_(less(field_ref("x"), literal(20)), greater(field_ref("x"), literal(0))); Review comment: Why this expression in particular? If we want to measure evaluation overhead, we should use a trivial expression, such as a cast from date64 to int64 (which is effectively zero-copy). ########## File path: cpp/src/arrow/compute/exec/expression_execution_benchmark.cc ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "benchmark/benchmark.h" + +#include "arrow/compute/cast.h" +#include "arrow/compute/exec/expression.h" +#include "arrow/compute/exec/test_util.h" +#include "arrow/dataset/partition.h" +#include "arrow/testing/generator.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/type.h" + +namespace arrow { +namespace compute { + +auto expression = + and_(less(field_ref("x"), literal(20)), greater(field_ref("x"), literal(0))); + +static void Execution(benchmark::State& state) { + const auto array_batches = static_cast<int32_t>(state.range(0)); + const auto array_size = 10000000 / array_batches; + + ExecContext ctx; + auto dataset_schema = schema({ + field("x", int64()), + }); + ExecBatch input({Datum(ConstantArrayGenerator::Int64(array_size, 5))}, + /*length=*/1); + + ASSIGN_OR_ABORT(auto bound, expression.Bind(*dataset_schema)); + for (auto _ : state) { + for (int it = 0; it < array_batches; ++it) Review comment: I don't understand what the point of `array_batches` is here. You're having a pure repetition loop inside another pure repetition loop :-) ########## File path: cpp/src/arrow/compute/exec/expression_execution_benchmark.cc ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "benchmark/benchmark.h" + +#include "arrow/compute/cast.h" +#include "arrow/compute/exec/expression.h" +#include "arrow/compute/exec/test_util.h" +#include "arrow/dataset/partition.h" +#include "arrow/testing/generator.h" +#include "arrow/testing/gtest_util.h" Review comment: Same question here. ########## File path: cpp/src/arrow/compute/exec/expression_execution_benchmark.cc ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "benchmark/benchmark.h" + +#include "arrow/compute/cast.h" +#include "arrow/compute/exec/expression.h" +#include "arrow/compute/exec/test_util.h" +#include "arrow/dataset/partition.h" Review comment: Is this include file required? ########## File path: cpp/src/arrow/compute/exec/CMakeLists.txt ########## @@ -36,6 +36,7 @@ add_arrow_compute_test(union_node_test PREFIX "arrow-compute") add_arrow_compute_test(util_test PREFIX "arrow-compute") add_arrow_benchmark(expression_benchmark PREFIX "arrow-compute") +add_arrow_benchmark(expression_execution_benchmark PREFIX "arrow-compute") Review comment: I'm not sure it's useful to create a separate executable for this. Simply add the benchmark to the existing expression benchmark file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
