emkornfield commented on a change in pull request #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r841092781
##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -33,13 +33,23 @@
namespace arrow {
namespace fs {
-struct GcsCredentials {
- explicit GcsCredentials(std::shared_ptr<google::cloud::Credentials> c)
+struct GcsCredentialsHolder {
+ explicit GcsCredentialsHolder(std::shared_ptr<google::cloud::Credentials> c)
: credentials(std::move(c)) {}
std::shared_ptr<google::cloud::Credentials> credentials;
};
+bool GcsCredentials::Equals(const GcsCredentials& other) const {
+ if (holder_->credentials == other.holder_->credentials) {
+ return true;
+ }
+ return anonymous_ == other.anonymous_ && access_token_ ==
other.access_token_ &&
Review comment:
There seems to be an expectation of being able to serialize/deserialize
the FS implementation via pickle. I didn't see any method directly on
credentials that would allow this, but happy to use this if one exists, along
with this comes the need for deep equality I think. Since credentials didn't
support this keeping all inputs seemed like the only viable way of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
