zagto commented on code in PR #12719:
URL: https://github.com/apache/arrow/pull/12719#discussion_r842736052
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -251,12 +251,12 @@ gaflight_client_new(GAFlightLocation *location,
arrow::Status status;
if (options) {
const auto flight_options = gaflight_client_options_get_raw(options);
- status = arrow::flight::FlightClient::Connect(*flight_location,
- *flight_options,
- &flight_client);
+ arrow::Result<std::unique_ptr<arrow::flight::FlightClient>> result =
arrow::flight::FlightClient::Connect(*flight_location,
+ *flight_options);
+ status = std::move(result).Value(&flight_client);
Review Comment:
For formatting, I thought archery would fix these things. Does it not check
GLib code?
The explicit type was left over from when I was debugging why the original
suggestion wouldn't work, I'll change it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
