lidavidm commented on code in PR #12789:
URL: https://github.com/apache/arrow/pull/12789#discussion_r843045927
##########
docs/source/developers/cpp/windows.rst:
##########
@@ -362,6 +362,20 @@ suppress dllimport/dllexport marking of symbols. Projects
that statically link
against Arrow on Windows additionally need this definition. The Unix builds do
not use the macro.
+In addition if using ``-DARROW_FLIGHT=ON``, ``ARROW_FLIGHT_STATIC`` needs to
+be defined.
+
+.. code-block:: cmake
+
+ project(MyExample)
+
+ find_package(Arrow REQUIRED)
+
+ add_executable(my_example my_example.cc)
+ target_link_libraries(my_example PRIVATE arrow_static arrow_flight_static)
+
+ add_compile_definitions(ARROW_STATIC ARROW_FLIGHT_STATIC)
Review Comment:
It's more idiomatic to use `target_compile_definitions` right?
##########
cpp/src/arrow/flight/sql/client.cc:
##########
@@ -369,8 +369,9 @@ arrow::Result<int64_t> PreparedStatement::ExecuteUpdate() {
} else {
const std::shared_ptr<Schema> schema = arrow::schema({});
ARROW_RETURN_NOT_OK(client_->DoPut(options_, descriptor, schema, &writer,
&reader));
+ const auto& columns = std::vector<std::shared_ptr<Array>>{};
Review Comment:
nit (assuming `arrow/type_fwd.h` is included):
```suggestion
ArrayVector columns;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
