tustvold commented on code in PR #2215:
URL: https://github.com/apache/arrow-datafusion/pull/2215#discussion_r848549751
##########
datafusion/core/src/physical_plan/hash_aggregate.rs:
##########
@@ -798,35 +751,23 @@ impl HashAggregateStream {
aggr_expr: Vec<Arc<dyn AggregateExpr>>,
input: SendableRecordBatchStream,
baseline_metrics: BaselineMetrics,
- ) -> Self {
- let (tx, rx) = futures::channel::oneshot::channel();
-
- let schema_clone = schema.clone();
- let elapsed_compute = baseline_metrics.elapsed_compute().clone();
- let join_handle = tokio::spawn(async move {
Review Comment:
This logic is moved into the Stream::poll_next
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
