pitrou commented on code in PR #12865:
URL: https://github.com/apache/arrow/pull/12865#discussion_r848662372
##########
cpp/src/arrow/vendored/datetime/tz.h:
##########
@@ -294,6 +294,40 @@ struct zoned_traits
{
};
+class OffsetZone {
Review Comment:
As a policy, we shouldn't add our own code inside vendored libraries. Just
put it somewhere else in the source tree (for example in a
`arrow/util/date_internal.h` where the vendored code would be included)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
