liukun4515 commented on PR #2192: URL: https://github.com/apache/arrow-datafusion/pull/2192#issuecomment-1098076947
> > I think we should add the function in > > https://github.com/apache/arrow-datafusion/blob/28a6da3d2d175eb9d2f4ff8a6ea58e7c22dae97c/ballista/rust/core/proto/datafusion.proto#L203 > > > > proto > > Yes , but there is some issue in #2221 but in df it just rewrite `APPROX_MEDIAN` to `APPROX_PERCENTILE(0.5)` My thought is that we should add ``` APPROX_PERCENTILE_CONT_WITH_WEIGHT = 16; ``` behind the `APPROX_MEDIAN=15; ` in the proto file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
