jorisvandenbossche commented on a change in pull request #8008:
URL: https://github.com/apache/arrow/pull/8008#discussion_r475540932



##########
File path: python/pyarrow/scalar.pxi
##########
@@ -687,6 +687,44 @@ cdef class DictionaryScalar(Scalar):
     Concrete class for dictionary-encoded scalars.
     """
 
+    def __init__(self, index, dictionary, type):

Review comment:
       Maybe we can put this in some `from_..` class method? (to keep it 
consistent with the other scalars that `__init__` raises)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to