sanjibansg commented on code in PR #12701:
URL: https://github.com/apache/arrow/pull/12701#discussion_r851429300
##########
cpp/src/arrow/dataset/dataset_writer.cc:
##########
@@ -476,7 +478,8 @@ class DatasetWriter::DatasetWriterImpl : public
util::AsyncDestroyable {
}
Future<> DoWriteRecordBatch(std::shared_ptr<RecordBatch> batch,
- const std::string& directory, const std::string&
prefix) {
+ const std::string& directory, const std::string&
prefix,
+ const bool& create_dir) {
Review Comment:
yes, sorry we don't need to pass it by reference. Yes, the parameter is
actually needed. Thanks for pointing that out, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
