liukun4515 commented on code in PR #2241:
URL: https://github.com/apache/arrow-datafusion/pull/2241#discussion_r851569242
##########
datafusion/physical-expr/src/coercion_rule/binary_rule.rs:
##########
@@ -557,15 +571,17 @@ mod tests {
DataType::Float32,
DataType::Float64,
DataType::Decimal(38, 10),
+ DataType::Decimal(20, 8),
];
let result_types = [
DataType::Decimal(20, 3),
DataType::Decimal(20, 3),
DataType::Decimal(20, 3),
- DataType::Decimal(20, 3),
- DataType::Decimal(20, 7),
- DataType::Decimal(30, 15),
+ DataType::Decimal(23, 3),
+ DataType::Decimal(24, 7),
+ DataType::Decimal(32, 15),
DataType::Decimal(38, 10),
+ DataType::Decimal(25, 8),
Review Comment:
This is inspired by your comments
https://github.com/apache/arrow-datafusion/pull/2200#discussion_r850030108
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
