paleolimbot commented on code in PR #12817:
URL: https://github.com/apache/arrow/pull/12817#discussion_r852239435
##########
r/R/type.R:
##########
@@ -69,16 +70,43 @@ FLOAT_TYPES <- c("float16", "float32", "float64",
"halffloat", "float", "double"
#' type(mtcars)
#' type(Sys.Date())
#' @export
-type <- function(x) UseMethod("type")
+type <- function(x, ...) UseMethod("type")
Review Comment:
..or `as_data_type` could be `as_type()`? (I don't remember why I didn't do
that in the first place). If renaming `type()` is an option, my vote would be
`infer_type()` or `infer_data_type()` since we're not exactly constructing a
type here, we're giving a hypothetical future type from something that might be
converted to an Array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
