emkornfield commented on a change in pull request #8011:
URL: https://github.com/apache/arrow/pull/8011#discussion_r476565438
##########
File path: go/arrow/type_traits_decimal128.go
##########
@@ -39,8 +40,13 @@ func (decimal128Traits) BytesRequired(n int) int { return
Decimal128SizeBytes *
// PutValue
func (decimal128Traits) PutValue(b []byte, v decimal128.Num) {
- binary.LittleEndian.PutUint64(b[:8], uint64(v.LowBits()))
- binary.LittleEndian.PutUint64(b[8:], uint64(v.HighBits()))
+ if runtime.GOARCH == "s390x" {
Review comment:
I found this an issue discussing
[DCE](https://github.com/golang/go/issues/21424) in Go. Skimming the thread it
seems that using build tags if feasible might be a better way to support
multiple architectures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
