jianxind commented on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-680399431


   > > Another potential approach is the ARROW_USER_SIMD_LEVEL flag during 
runtime, something like "ARROW_USER_SIMD_LEVEL=avx2 make unittest", I'm not 
familiar with CI system thus don't know if it's easy to hook 
ARROW_USER_SIMD_LEVEL flag.
   > 
   > We can change environment variables only for test in CI.
   > 
   > But I don't know whether Valgrind can work with binary that has AVX512 
instructions or not...
   
   Probably yes I think, as current approach only disable the AVX512 register 
path, the AVX512 file is still built into the lib.
   
   The AVX512 file is defined under CXX_SUPPORTS_AVX512 flag
   ```
   if(CXX_SUPPORTS_AVX512)
     list(APPEND ARROW_SRCS util/bpacking_avx512.cc)
     set_source_files_properties(util/bpacking_avx512.cc PROPERTIES 
SKIP_PRECOMPILE_HEADERS
                                 ON)
     set_source_files_properties(util/bpacking_avx512.cc PROPERTIES 
COMPILE_FLAGS
                                 ${ARROW_AVX512_FLAG})
   endif()
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to