rok commented on code in PR #12657:
URL: https://github.com/apache/arrow/pull/12657#discussion_r855176391
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2078,6 +2078,19 @@ def _check_temporal_rounding(ts, values, unit):
expected = ts.dt.round(frequency)
np.testing.assert_array_equal(result, expected)
+ # TODO: should work for day
Review Comment:
Pandas doesn't have the `strict_ceil` concept so we generate data for the
test. We don't really need to test this IMO as it will be checked against
lubridate anyway which will surface bugs if any. I'm removing the TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
