HaoYang670 commented on code in PR #1608:
URL: https://github.com/apache/arrow-rs/pull/1608#discussion_r856785189
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -25,7 +26,68 @@ use crate::{
};
use std::cmp::Ordering;
-fn generic_substring<OffsetSize: StringOffsetSizeTrait>(
+fn binary_substring<OffsetSize: BinaryOffsetSizeTrait>(
Review Comment:
The implementation is similar to `utf8_substring` expect that there is no
char boundary checking.
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -25,7 +26,68 @@ use crate::{
};
use std::cmp::Ordering;
-fn generic_substring<OffsetSize: StringOffsetSizeTrait>(
+fn binary_substring<OffsetSize: BinaryOffsetSizeTrait>(
Review Comment:
The implementation is similar to `utf8_substring` except that there is no
char boundary checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
