liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478230891
##########
File path: cpp/src/arrow/compare.cc
##########
@@ -862,7 +862,11 @@ class TypeEqualsVisitor {
class ScalarEqualsVisitor {
public:
- explicit ScalarEqualsVisitor(const Scalar& right) : right_(right),
result_(false) {}
+ explicit ScalarEqualsVisitor(const Scalar& right)
+ : right_(right), result_(false), options_(EqualOptions()) {}
+
+ explicit ScalarEqualsVisitor(const Scalar& right, const EqualOptions& opts)
Review comment:
Good suggestion. Thank you.
##########
File path: cpp/src/arrow/compare.h
##########
@@ -113,4 +113,11 @@ bool ARROW_EXPORT TypeEquals(const DataType& left, const
DataType& right,
/// \param[in] right a Scalar
bool ARROW_EXPORT ScalarEquals(const Scalar& left, const Scalar& right);
+/// Returns true if scalars are equal
+/// \param[in] left a Scalar
+/// \param[in] right a Scalar
+/// \param[in] options comparison options
+bool ARROW_EXPORT ScalarEquals(const Scalar& left, const Scalar& right,
+ const EqualOptions& options);
Review comment:
Accepted. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
