vibhatha commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r862281448
##########
cpp/src/arrow/compute/kernels/scalar_arithmetic.cc:
##########
@@ -2075,7 +2075,7 @@ Status ExecRound(KernelContext* ctx, const ExecBatch&
batch, Datum* out) {
// kernel dispatch based on RoundMode, only on non-null output.
template <template <typename, RoundMode, typename...> class Op, typename
OptionsType>
std::shared_ptr<ScalarFunction> MakeUnaryRoundFunction(std::string name,
- const FunctionDoc* doc)
{
+ FunctionDoc doc) {
using State = RoundOptionsWrapper<OptionsType>;
static const OptionsType kDefaultOptions = OptionsType::Defaults();
auto func = std::make_shared<ArithmeticIntegerToFloatingPointFunction>(
Review Comment:
I found another few places too, I updated them as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
