tustvold commented on code in PR #2444: URL: https://github.com/apache/arrow-datafusion/pull/2444#discussion_r865592842
########## dev/format-code.sh: ########## @@ -0,0 +1,22 @@ +#!/bin/bash Review Comment: What are people's thoughts on merging the `lint`, `clippy` and `cargo-toml-formatting-checks` into a single `lint` check, moving this to script `ci/scripts/rust_lint.sh`, and running it from CI? This will ensure it remains up to date? @alamb @andygrove ?? ########## dev/format-code.sh: ########## @@ -0,0 +1,22 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +set -e +cargo fmt --all Review Comment: ```suggestion if ! command -v cargo-tomlfmt &> /dev/null; then echo "Installing cargo-tomlfmt using cargo" cargo install cargo-tomlfmt fi cargo fmt --all ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
