rok commented on PR #12657: URL: https://github.com/apache/arrow/pull/12657#issuecomment-1118963132
> Sorry for the slow response! No worries. Thank you for the review! > Do we know if "strict ceil" is a typical term for this behaviour? (it could also be "ceil_on_boundary" to make it more explicit about "ceil") The reason we're adding this behaviour is lubridate and there the parameter is called `change_on_boundary`, e.g.: ``` ceiling_date(x, unit="day", change_on_boundary=FALSE) ceiling_date(x, unit="day", change_on_boundary=TRUE) ``` [Docs here](https://lubridate.tidyverse.org/reference/round_date.html). There is another odd behaviour where `change_on_boundary=NULL` is the same as `change_on_boundary=TRUE` for dates but not other types. I think we best tackle that in R wrapper. To me `x_on_boundary` sounds better than `strict_x` but I don't feel strongly about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
