rok commented on code in PR #12657:
URL: https://github.com/apache/arrow/pull/12657#discussion_r866806638
##########
cpp/src/arrow/compute/api_scalar.h:
##########
@@ -117,6 +118,13 @@ class ARROW_EXPORT RoundTemporalOptions : public
FunctionOptions {
CalendarUnit unit;
/// What day does the week start with (Monday=true, Sunday=false)
bool week_starts_monday;
+ /// Times exactly on unit multiple boundary will be rounded one unit
multiple up.
+ /// This applies for ceiling only.
+ bool strict_ceil;
+ /// By default origin is 1970-01-01T00:00:00. By setting this to true,
rounding origin
+ /// will be beginning of one less precise calendar unit. E.g. rounding to
hours will use
+ /// beginning of day as origin.
+ bool calendar_based_origin;
Review Comment:
Yeah, only for `multiple != 1`. `multiple_since_greater_unit` sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
