Ted-Jiang commented on code in PR #2499: URL: https://github.com/apache/arrow-datafusion/pull/2499#discussion_r870003789
########## datafusion/core/src/physical_plan/file_format/parquet.rs: ########## @@ -425,7 +437,8 @@ impl Stream for ParquetExecStream { mut self: Pin<&mut Self>, _cx: &mut Context<'_>, ) -> Poll<Option<Self::Item>> { - Poll::Ready(Iterator::next(&mut *self)) + let poll = Poll::Ready(Iterator::next(&mut *self)); + self.baseline_metrics.record_poll(poll) Review Comment: I think we remove `async` so will never call poll. But i think we should keep this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org