[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2512: Remove remaining uses of `binary_array_op_scalar!` in binary.rs

[GitBox]

alamb commented on code in PR #2512:
URL: https://github.com/apache/arrow-datafusion/pull/2512#discussion_r870303487


##########
datafusion/physical-expr/src/expressions/nullif.rs:
##########
@@ -82,18 +80,18 @@ pub fn nullif_func(args: &[ColumnarValue]) -> 
Result<ColumnarValue> {
 
     match (lhs, rhs) {
         (ColumnarValue::Array(lhs), ColumnarValue::Scalar(rhs)) => {
-            let cond_array = binary_array_op_scalar!(lhs, rhs.clone(), 
eq).unwrap()?;
+            let cond_array = array_eq_scalar(lhs, rhs)?;
 
             let array = primitive_bool_array_op!(lhs, *cond_array, nullif)?;
 
             Ok(ColumnarValue::Array(array))
         }
         (ColumnarValue::Array(lhs), ColumnarValue::Array(rhs)) => {
             // Get args0 == args1 evaluated and produce a boolean array
-            let cond_array = binary_array_op!(lhs, rhs, eq)?;
+            let cond_array = eq_dyn(lhs, rhs)?;

Review Comment:
   Hooray for `eq_dyn` thanks again @Jimexist 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org