[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2511: Minor: remove code that is not included in arrow-rs

Wed, 11 May 2022 06:33:38 -0700 


alamb commented on code in PR #2511:
URL: https://github.com/apache/arrow-datafusion/pull/2511#discussion_r870255936


##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -61,14 +61,6 @@ use datafusion_common::{DataFusionError, Result};
 use datafusion_expr::binary_rule::binary_operator_data_type;
 use datafusion_expr::{binary_rule::coerce_types, ColumnarValue, Operator};
 
-// TODO move to arrow_rs

Review Comment:
   The fact I didn't have to `use` the copy in arrow confused me for a bit
   
   Then I realized it is included by the following:
    
   ```rust
   use arrow::array::*;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to