nealrichardson commented on code in PR #13131: URL: https://github.com/apache/arrow/pull/13131#discussion_r871689730
########## ci/docker/centos-7-cpp.dockerfile: ########## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM centos:centos7 + +RUN yum install -y \ + diffutils \ + gcc-c++ \ + libcurl-devel \ + make \ + openssl-devel \ + wget \ + which + +# yum install cmake version is too old + +ARG cmake=3.18.1 Review Comment: You could upgrade and let CI tell you if it's fine 🤠Searching for `ARG cmake` I find three other instances: One with a comment pointing to an issue that has been fixed, one using the same version as that but with no comment, and another older one with no comment. We could trace those back through but I'd be willing to guess if there's no note explaining why it needs to be pinned on an older version, it's probably because that was the newest version at the time. Specifically for this case, coming from arrow-r-nightly, I can confirm that that's why it is on this version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
