vibhatha commented on code in PR #13150:
URL: https://github.com/apache/arrow/pull/13150#discussion_r880347828
##########
r/R/query-engine.R:
##########
@@ -121,11 +119,13 @@ ExecPlan <- R6Class("ExecPlan",
x
})
}
+ target_names <- names(.data$aggregations)
+ for (i in seq_len(length(target_names))) {
+ .data$aggregations[[i]][["name"]] <-
.data$aggregations[[i]][["target"]] <- target_names[i]
Review Comment:
@nealrichardson Since you pointed out the `names` and `target` being the
same, in previous implementation they were set to the same value. As far as I
understood, the test cases are also following that. Is it wise to affix this or
just leave it as it is? I have doubts about which one to select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
