zeroshade commented on code in PR #13221:
URL: https://github.com/apache/arrow/pull/13221#discussion_r881107743
##########
go/parquet/file/column_reader_types.gen.go:
##########
@@ -207,10 +207,11 @@ type BooleanColumnChunkReader struct {
func (cr *BooleanColumnChunkReader) Skip(nvalues int64) (int64, error) {
return cr.columnChunkReader.skipValues(nvalues,
func(batch int64, buf []byte) (int64, error) {
+ // buf is large enough to hold values, but not to hold
def and rep lvls; use nil for them
vals, _, err := cr.ReadBatch(batch,
*(*[]bool)(unsafe.Pointer(&buf)),
- arrow.Int16Traits.CastFromBytes(buf),
- arrow.Int16Traits.CastFromBytes(buf))
+ nil,
+ nil)
Review Comment:
Please update the corresponding `.tmpl` file so that future calls to `go
generate` don't clobber this. Otherwise this LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
