kszucs commented on pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#issuecomment-688731266


   @romainfrancois since the conversion code in `python_to_arrow.cc` and 
`r/src/array_from_vector.cpp` are pretty similar it would be nice to reuse as 
much code as we could (including new features like auto chunking large inputs). 
   
   Could you please take a look at the base classes in 
[converter.h](https://github.com/apache/arrow/blob/0a384d574fde83324d4949a56220e6cda8527816/cpp/src/arrow/util/converter.h)
 to see whether would it help/improve the R side implementation? I have not 
documented it yet because it's still under discussion but you can take a look 
how I'm using it [in the python 
bindings](https://github.com/apache/arrow/blob/0a384d574fde83324d4949a56220e6cda8527816/cpp/src/arrow/python/python_to_arrow.cc#L351-L802).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to