nealrichardson commented on code in PR #13150:
URL: https://github.com/apache/arrow/pull/13150#discussion_r886879521
##########
r/R/query-engine.R:
##########
@@ -114,11 +112,13 @@ ExecPlan <- R6Class("ExecPlan",
x
})
}
+ target_names <- names(.data$aggregations)
+ for (i in seq_len(length(target_names))) {
+ .data$aggregations[[i]][["name"]] <-
.data$aggregations[[i]][["target"]] <- target_names[i]
+ }
Review Comment:
Maybe using
[`purrr::imap()`](https://purrr.tidyverse.org/reference/imap.html) here will
make the lint warning go away? I don't see how this current version is more
complex than what is currently on master.
```suggestion
.data$aggregations <- imap(.data$aggregations, function(x, name) {
# Embed the name inside the aggregation objects
# `target` and `name` are the same because we Project the data
that way
x[["name"]] <- x[["target"]] <- name
x
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
