vibhatha commented on code in PR #13205:
URL: https://github.com/apache/arrow/pull/13205#discussion_r887598656
##########
cpp/src/arrow/dataset/scanner.cc:
##########
@@ -74,6 +74,13 @@ class ScannerRecordBatchReader : public RecordBatchReader {
TaggedRecordBatchIterator delegate)
: schema_(std::move(schema)), delegate_(std::move(delegate)) {}
+ ~ScannerRecordBatchReader() {
+ auto st = this->Close();
+ if (!st.ok()) {
+ ARROW_LOG(WARNING) << "ScannerRecordBatchReader failed in finalzing
reading.";
Review Comment:
Yes, may be now we don't need this as we modified the base class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
