wjones127 commented on code in PR #13206:
URL: https://github.com/apache/arrow/pull/13206#discussion_r888083810
##########
cpp/src/arrow/filesystem/s3fs.h:
##########
@@ -218,6 +229,12 @@ class ARROW_EXPORT S3FileSystem : public FileSystem {
/// Return the actual region this filesystem connects to
std::string region() const;
+ /// Set create_buckets property of options
Review Comment:
> These trivial setters are not needed as people can access the attributes
directly.
I'm not so sure that's true. This fails:
```cpp
auto options = fs_->options();
options.allow_bucket_creation = true;
options.allow_bucket_deletion = true;
ASSERT_EQ(fs_->options().allow_bucket_creation, true);
ASSERT_EQ(fs_->options().allow_bucket_deletion, true);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
