kou commented on code in PR #13292: URL: https://github.com/apache/arrow/pull/13292#discussion_r890849903
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -1011,7 +983,7 @@ if(ARROW_BUILD_INTEGRATION set(ARROW_USE_BOOST TRUE) set(ARROW_BOOST_REQUIRE_LIBRARY TRUE) elseif(ARROW_GANDIVA - OR (ARROW_WITH_THRIFT AND THRIFT_REQUIRES_BOOST) + OR ARROW_WITH_THRIFT Review Comment: Yes. The condition was wrong. We needs Boost to use Thrift. We need Thrift only when we use Parquet or `arrow/dbi/hiveserver2/`. Parquet uses `thrift/transport/TBufferTransports.h`: https://github.com/apache/arrow/blob/master/cpp/src/parquet/thrift_internal.h#L43 `thrift/transport/TBufferTransports.h` uses Boost: https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/TBufferTransports.h#L26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
