iChauster commented on code in PR #13302: URL: https://github.com/apache/arrow/pull/13302#discussion_r892773713
########## cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc: ########## @@ -172,6 +194,10 @@ auto non_zoned = timestamp(TimeUnit::NANO); #define DECLARE_TEMPORAL_BENCHMARKS_ZONED(OP) \ BENCHMARK_TEMPLATE(BenchmarkTemporal, OP, zoned)->Apply(SetArgs); +#define DECLARE_TEMPORAL_BINARY_BENCHMARKS(OP) \ + BENCHMARK_TEMPLATE(BenchmarkTemporalBinary, OP, non_zoned)->Apply(SetArgs); \ + BENCHMARK_TEMPLATE(BenchmarkTemporalBinary, OP, zoned)->Apply(SetArgs); Review Comment: Hi @rok, thank you for the clarification! I refactored the code to work for the other data types, however it seems like (many of) these temporal binary functions [currently do not support any other datatype](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/scalar_temporal_binary.cc#L461) than `Int64`. When running my code with something like `date32` or `time64` with `random.ArrayOf`, I get an `NotImplemented: Function years_between has no kernel matching input types (array[time64[ns]], array[time64[ns]])`, Let me know if I've missed a detail! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
