Ismail-Maj commented on code in PR #1787:
URL: https://github.com/apache/arrow-rs/pull/1787#discussion_r893310802
##########
arrow/src/compute/kernels/concat_elements.rs:
##########
@@ -29,54 +29,76 @@ use crate::error::{ArrowError, Result};
///
/// ["Hello"] + ["World"] = ["HelloWorld"]
///
-/// ["a", "b"] + [None, "c"] = [None, "bc"]
+/// ["a", "b"] + [None, "c"] + [None, "d"] = [None, "bcd"]
/// ```
///
-/// An error will be returned if `left` and `right` have different lengths
+/// An error will be returned if the [`StringArray`] are of different lengths.
pub fn concat_elements_utf8<Offset: OffsetSizeTrait>(
- left: &GenericStringArray<Offset>,
- right: &GenericStringArray<Offset>,
+ arrays: &[&GenericStringArray<Offset>],
) -> Result<GenericStringArray<Offset>> {
- if left.len() != right.len() {
+ if arrays.len() < 2 {
Review Comment:
the code is quite complex to make it work for one element, I've tried
without the second condition and it works :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
