amol- commented on code in PR #13311:
URL: https://github.com/apache/arrow/pull/13311#discussion_r894525752
##########
cpp/cmake_modules/FindArrowPython.cmake:
##########
@@ -46,8 +46,9 @@ endif()
find_package(Arrow ${find_package_arguments})
if(ARROW_FOUND)
+ message(STATUS "CPYARROW_HOME: ${CPYARROW_HOME}")
arrow_find_package(ARROW_PYTHON
- "${ARROW_HOME}"
+ "${CPYARROW_HOME}"
Review Comment:
This smells a bit hackish. Feels a bit like we are building two totally
different projects.
On long term we should probably have `libarrow_python.so` just be one of the
shared objects constituting pyarrow. `libarrow_python.so` should probably be
possible to integrate with the rest of the built files using `add_subdirectory`
or something equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
